From 07982f681ae5abdf6318b4f2f231e7ca925b4470 Mon Sep 17 00:00:00 2001
From: Julien Duchesne <jduchesne@coveo.com>
Date: Thu, 18 Jul 2019 15:38:50 -0400
Subject: [PATCH] Optimized nav generation
- Trimmed whitespace between html elements
This reduced one of my files from 850KB to 115KB
- Do not sort the whole list of pages on every iteration
This made build 3x faster
---
_includes/nav.html | 64 ++++++++++++++++++++++------------------------
1 file changed, 30 insertions(+), 34 deletions(-)
diff --git a/_includes/nav.html b/_includes/nav.html
index 2c4bf1ea..d561a42a 100644
--- a/_includes/nav.html
+++ b/_includes/nav.html
@@ -1,44 +1,40 @@
<nav role="navigation" aria-label="Main navigation">
<ul class="navigation-list">
- {% assign pages_list = site.html_pages | sort:"nav_order" %}
- {% for node in pages_list %}
- {% unless node.nav_exclude %}
- {% if node.parent == nil %}
+ {%- assign pages_list = site.html_pages | sort:"nav_order" -%}
+ {%- for node in pages_list -%}
+ {%- unless node.nav_exclude -%}
+ {%- if node.parent == nil -%}
<li class="navigation-list-item{% if page.url == node.url or page.parent == node.title or page.grand_parent == node.title %} active{% endif %}">
- {% if page.parent == node.title or page.grand_parent == node.title %}
- {% assign first_level_url = node.url | absolute_url %}
- {% endif %}
+ {%- if page.parent == node.title or page.grand_parent == node.title -%}
+ {%- assign first_level_url = node.url | absolute_url -%}
+ {%- endif -%}
<a href="{{ node.url | absolute_url }}" class="navigation-list-link{% if page.url == node.url %} active{% endif %}">{{ node.title }}</a>
- {% if node.has_children %}
- {% assign children_list = site.html_pages | sort:"nav_order" %}
+ {%- if node.has_children -%}
+ {%- assign children_list = site.html_pages | where: "parent", node.title | sort:"nav_order" -%}
<ul class="navigation-list-child-list ">
- {% for child in children_list %}
- {% if child.parent == node.title %}
- <li class="navigation-list-item {% if page.url == child.url or page.parent == child.title %} active{% endif %}">
- {% if page.url == child.url or page.parent == child.title %}
- {% assign second_level_url = child.url | absolute_url %}
- {% endif %}
- <a href="{{ child.url | absolute_url }}" class="navigation-list-link{% if page.url == child.url %} active{% endif %}">{{ child.title }}</a>
- {% if child.has_children %}
- {% assign grand_children_list = site.html_pages | sort:"nav_order" %}
+ {%- for child in children_list -%}
+ <li class="navigation-list-item {% if page.url == child.url or page.parent == child.title %} active{% endif %}">
+ {%- if page.url == child.url or page.parent == child.title -%}
+ {%- assign second_level_url = child.url | absolute_url -%}
+ {%- endif -%}
+ <a href="{{ child.url | absolute_url }}" class="navigation-list-link{% if page.url == child.url %} active{% endif %}">{{ child.title }}</a>
+ {%- if child.has_children -%}
+ {%- assign grand_children_list = site.html_pages | where: "parent", child.title | sort:"nav_order" -%}
<ul class="navigation-list-child-list">
- {% for grand_child in grand_children_list %}
- {% if grand_child.parent == child.title %}
- <li class="navigation-list-item {% if page.url == grand_child.url %} active{% endif %}">
- <a href="{{ grand_child.url | absolute_url }}" class="navigation-list-link{% if page.url == grand_child.url %} active{% endif %}">{{ grand_child.title }}</a>
- </li>
- {% endif %}
- {% endfor %}
- </ul>
- {% endif %}
- </li>
- {% endif %}
- {% endfor %}
+ {%- for grand_child in grand_children_list -%}
+ <li class="navigation-list-item {% if page.url == grand_child.url %} active{% endif %}">
+ <a href="{{ grand_child.url | absolute_url }}" class="navigation-list-link{% if page.url == grand_child.url %} active{% endif %}">{{ grand_child.title }}</a>
+ </li>
+ {%- endfor -%}
+ </ul>
+ {%- endif -%}
+ </li>
+ {%- endfor -%}
</ul>
- {% endif %}
+ {%- endif -%}
</li>
- {% endif %}
- {% endunless %}
- {% endfor %}
+ {%- endif -%}
+ {%- endunless -%}
+ {%- endfor -%}
</ul>
</nav>
--
GitLab