Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • GECCO GECCO
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Zeller Group
  • GECCOGECCO
  • Merge requests
  • !12

Merged
Created May 14, 2020 by Martin Larralde@larraldeMaintainer

Fix FET feature selection causing some data to be erased from marginals prediction

  • Overview 0
  • Commits 3
  • Pipelines 1
  • Changes 2

With the current implementation, the input data passed to ClusterCRF.predict_marginals and the output table (theoretically the same table with an extract p_pred column) would have rows without significant features (the ones determined on fitting) removed. This impacts downstream analysis of precision/recall, since the number of TP,FP,TN,FN is likely affected by this bug.

I also added a test case (which failed before the patch) to make sure the bugfix works as expected and that no regression happens.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-fet