WIP:Fonts/ebi icon fonts (!98) · Merge requests · Communications / visual-framework · GitLab

Snippets Groups Projects

This is an archived project. Repository and other project resources are read-only.

Open Ken Hawkins requested to merge fonts/ebi-icon-fonts into features/font-source 6 years ago

This is an exploration that raises a few ideas/questions:

How should we deal with patterns that are largely and npm install of another repo?
Here, the ebi-icon-fonts probably need a .ebi-icon-fonts wrapper and some other customer scss tweaks. This will probably be common... so how do we recommend people do this? Make a fork?

Edited 6 years ago by Ken Hawkins

Activity

Ken Hawkins changed the description 6 years ago

changed the description
Ken Hawkins changed target branch from develop to features/font-source 6 years ago

changed target branch from develop to features/font-source
Ken Hawkins added 1 commit 6 years ago
added 1 commit

d0595826 - fonts/ebi-icon-fonts

Compare with previous version
Ken Hawkins added 1 commit 6 years ago
added 1 commit

f14aba5f - Nest icons under pattern of .ebi-icon-fonts

Compare with previous version
Stu Robson @robson · 6 years ago

Contributor

Target branch does not exist. Please restore it or use a different target branch ...

@khawkins did I merge in the wrong order?
Ken Hawkins @khawkins · 6 years ago

Author Contributor

It's OK, I don't know that this is necessarily ready to go in yet. We should chat about it maybe.

Please register or sign in to reply