Added some TODOs

model_server/base/pipelines/segment.py

@@ -19,6 +19,7 @@ class SegmentRecord(PipelineRecord):
     pass
 
 
+# TODO: simple threshold seg model (issue0045)
 @router.put('/segment')
 def segment(p: SegmentParams) -> SegmentRecord:
     """

model_server/base/pipelines/shared.py

@@ -45,6 +45,8 @@ class PipelineRecord(BaseModel):
 def call_pipeline(func, p: PipelineParams) -> PipelineRecord:
     # match accessor IDs to loaded accessor objects
     accessors_in = {}
+
+    # TODO: remove "model" from model.keys()
     for k, v in p.dict().items():
         if k.endswith('accessor_id'):
             accessors_in[k.split('_id')[0]] = session.get_accessor(v, pop=True)

model_server/extensions/ilastik/models.py

@@ -14,6 +14,7 @@ from ...base.accessors import PatchStack
 from ...base.accessors import GenericImageDataAccessor, InMemoryDataAccessor
 from ...base.models import Model, ImageToImageModel, InstanceSegmentationModel, InvalidInputImageError, ParameterExpectedError, SemanticSegmentationModel
 
+# TODO: move params models to router only; model classes to be created only with dict
 class IlastikParams(BaseModel):
     project_file: str = Field(description='(*.ilp) ilastik project filename')
     duplicate: bool = Field(

scripts/run_server.py

@@ -42,7 +42,7 @@ def parse_args():
     return parser.parse_args()
 
 
-
+# TODO: move server logic into package
 def main(args) -> None:
 
     print('CLI args:\n' + str(args))