Added feedback color variable for nav item/search result hover

(cherry picked from commit f25d76730b175fb680aa2770fb20a67fd858ffbb)

_sass/color_schemes/dark.scss

@@ -15,3 +15,4 @@ $base-button-color: $grey-dk-250;
 $code-background-color: $grey-dk-250;
 $search-background-color: $grey-dk-250;
 $table-background-color: $grey-dk-250;
+$feedback-color: darken($sidebar-color, 3%);

_sass/layout.scss

@@ -165,7 +165,7 @@
 
 .site-title:hover,
 .site-button:hover {
-  background-color: darken($sidebar-color, 3%);
+  background-color: $feedback-color;
 }
 
 // stylelint-disable selector-max-type

_sass/navigation.scss

@@ -32,7 +32,7 @@
 
       &:hover,
       &.active {
-        background-color: darken($sidebar-color, 3%);
+        background-color: $feedback-color;
       }
     }
 
@@ -47,7 +47,7 @@
       fill: $link-color;
 
       &:hover {
-        background-color: darken($sidebar-color, 3%);
+        background-color: $feedback-color;
       }
     }
 

_sass/search.scss

@@ -112,7 +112,7 @@
 
   &:hover,
   &.active {
-    background-color: $sidebar-color;
+    background-color: $feedback-color;
   }
 
   @include mq(md) {

_sass/support/_variables.scss

@@ -56,6 +56,7 @@ $sidebar-color: $grey-lt-000 !default;
 $search-background-color: $white !default;
 $table-background-color: $white !default;
 $code-background-color: $grey-lt-000 !default;
+$feedback-color: darken($sidebar-color, 3%) !default;
 
 $body-text-color: $grey-dk-100 !default;
 $body-heading-color: $grey-dk-300 !default;

assets/js/just-the-docs.js

@@ -27,6 +27,7 @@ function initNav() {
   jtd.addEvent(document, 'click', function(e){
     var expander = e.path.find(function(x){ return x.classList && x.classList.contains('nav-list-expander') });
     if (expander) {
+      e.preventDefault();
       expander.parentElement.classList.toggle('active');
     }
   });