Skip to content
Snippets Groups Projects
Commit 260f9c3a authored by Christopher Randolph Rhodes's avatar Christopher Randolph Rhodes
Browse files

Cleaned up TODOs, tests pass

parent 8863f3fa
No related branches found
No related tags found
2 merge requests!102Merge staging as release,!72Pipeline task management
......@@ -131,7 +131,6 @@ def delete_accessor(accessor_id: str):
else:
return _session_accessor(session.del_accessor, accessor_id)
# TODO: optional lazy loading, so that batch task can be queued before file data is loaded
@app.put('/accessors/read_from_file/{filename}')
def read_accessor_from_file(filename: str, accessor_id: Union[str, None] = None):
fp = session.paths['inbound_images'] / filename
......@@ -228,12 +227,4 @@ def get_task(task_id: str) -> TaskInfo:
@app.get('/tasks')
def list_tasks() -> Dict[str, TaskInfo]:
res = session.tasks.list_tasks()
return res
# TODO: implement
@app.put('/tasks/run/on_files')
def task_file_batch():
# new callable that parameterizes file name to acc_id, then passes this to to /tasks/*/run
pass
# TODO: tasks to run all enqueued items
\ No newline at end of file
return res
\ No newline at end of file
......@@ -58,7 +58,7 @@ class RoiSetObjectMapParams(PipelineParams):
class RoiSetToObjectMapRecord(PipelineRecord):
pass
# TODO: shorten endpoint name, maybe simplify return typespec
@router.put('/roiset_to_obmap/infer')
def roiset_object_map(p: RoiSetObjectMapParams) -> Union[RoiSetToObjectMapRecord, PipelineQueueRecord]:
"""
......
......@@ -147,7 +147,6 @@ class _Session(object):
raise InvalidPathError(f'Could not find {path}')
self.paths[key] = Path(path)
# TODO: option to automatically write to file e.g. in automated task queue processing
def add_accessor(self, acc: GenericImageDataAccessor, accessor_id: str = None) -> str:
"""
Add an accessor to session context
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment